Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Run CircleCI with and without Apps Framework enabled #10707

Closed
wants to merge 2 commits into from

Conversation

Hudell
Copy link
Contributor

@Hudell Hudell commented May 8, 2018

Changes CircleCI configuration to run the tests with and without the Apps Framework

@Hudell Hudell requested a review from sampaiodiego May 8, 2018 21:29
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10707 May 8, 2018 21:30 Inactive
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the new jobs to run you have to add them into workflows

Copy link
Contributor

@graywolf336 graywolf336 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be converting this to a setting, so let's not merge this as it will need another change in the future.

@Hudell
Copy link
Contributor Author

Hudell commented May 9, 2018

@graywolf336 I think we can merge it anyway, there's no problem in changing it later and it may be able to detect a few problems like the one we had this week.

@graywolf336
Copy link
Contributor

Can you fill me in? I wasn't aware of an issue related to Apps.

@Hudell
Copy link
Contributor Author

Hudell commented May 9, 2018

#10671 #10705

Took us a while to figure out it was caused by the App Framework, as it didn't happen on our localhosts.

@geekgonecrazy
Copy link
Contributor

Do we still want this? Or should we close this out?

@sampaiodiego
Copy link
Member

idk.. we had an issue at some point that happened only with apps enabled.. but I'm not sure how buggy it's right now that we would still need this.

@sampaiodiego
Copy link
Member

@rodrigok wdyt?

@rodrigok
Copy link
Member

rodrigok commented Oct 1, 2018

@sampaiodiego It's important.
@Hudell can you change the env var to the setting override?

@Hudell Hudell closed this Apr 23, 2019
@graywolf336 graywolf336 deleted the add-apps-to-circleci branch April 23, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants