Mail messages #1733
Merged
Mail messages #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: packages/rocketchat-channel-settings/client/views/channelSettings.coffee
| localeFn = Meteor.call 'loadLocale', data.language | ||
| if localeFn | ||
| Function(localeFn)() | ||
| moment.locale(data.language) |
There was a problem hiding this comment.
Here are you changing the locale forever?
What happens if you send a mail in PT then another one in EN?
There was a problem hiding this comment.
Right! I should have used localMoment = moment().locale(...). I'll fix that.
|
@marceloschmidt prints? 😸 |
|
is it intended to an user from any access level (not only admins) be able to send the conversation by email? |
|
Should we create roles for that? |
|
A permission at least.. So admins can create their own roles with that permission. |
|
|
|
Added |
|
LGTM |
|
lgtm |
This was referenced Jan 11, 2022
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.