Faster desktop notifications

[mccambridge]

@RocketChat/core

Adds setting under General -> Notifications to set the number of seconds a desktop notification should appear in the browser (defaults to 5 sec). Currently, Chrome defaults to 20 seconds, and this is somewhat annoying.

Implemented Notification.close() in notifications.coffee in a setTimeout with the duration of the timeout equal to the settings value provided (x1000ms).

[rodrigok]

@mccambridge Are you using OS X? I think that this remove the notification from the notification central.

[mccambridge]

@rodrigok Yes, I'm on OS X. I don't think these notifications add anything to notification central. These are just pop-up desktop notifications as far as I can tell. The timeout just closes it. https://developer.mozilla.org/en-US/docs/Web/API/notification

[mccambridge]

If you'd like to see a fake notification using the same timeout, you can run:

const n = new Notification('lala', { body: 'yada', silent: true}); setTimeout(() => n.close(), 5000)

in a web console.

[rodrigok]

@mccambridge Yes, the notifications goes to OS X notification center, see #1866 and #1890

As you can see here https://github.com/RocketChat/Rocket.Chat/pull/1890/files, we removed the close timeout to keep notifications in notification center.

[mccambridge]

Okay, got it. Personally, I don't use notification center and would rather not see the notification linger for so long. But that's just my opinion.

What do you think about a setting where the administrator could choose whether or not to set the timeout?

[rodrigok]

@mccambridge an option of notification timeout is a good idea, 0 could be disabled

[mccambridge]

@rodrigok okay, updated to include 0 as an option, by which the timeout would not be set. 0 is the default value.

[geekgonecrazy]

@mccambridge So just to confirm when 0 they will behave as they do currently?

[mccambridge]

Exactly. And default is 0, so default is they behave as they do currently.

[rodrigok]

LGTM

[rodrigok]

@RocketChat/core Someone can review to give the second lgtm?

[sampaiodiego]

LGTM

[mccambridge]

Thanks, y'all!