feat: New users page active tab #32024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 79b0324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rique223
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32024 +/- ##
===========================================
- Coverage 55.54% 54.39% -1.15%
===========================================
Files 2633 2554 -79
Lines 57197 56026 -1171
Branches 11848 11623 -225
===========================================
- Hits 31768 30474 -1294
- Misses 22743 22941 +198
+ Partials 2686 2611 -75
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks like this PR is ready to merge! 🎉 |
rique223
force-pushed
the
feat/new-user-panel-active
branch
from
5e31c7a
to
c6e5b7f
Compare
Added a new "active" tab to the users page table, this tab lists the users that haved logged in for the first time and are active. Also, implemented a roles filtering component, improved the MultiSelectCustom and created the necessary new translation keys.
Changed the implementation of the new users table filters from a fully custom "Box based" code to a standardized use of the FilterByText component with children. Also improved the positioning and styling of the MultiSelectCustom by properly implementing the useOutsideClick and usePosition custom hooks together with reusing the fuselage button and input styles in the anchor of the component.
tassoevan
force-pushed
the
feat/new-user-panel-active
branch
from
66844ff
to
d315d45
Compare
tassoevan
approved these changes
Jul 16, 2024
rique223
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Implemented a new "active" tab to the users page table, this tab lists the users that haved logged in for the first time and are active. Also, implemented a roles filtering component, improved the MultiSelectCustom and created the necessary new translation keys.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
Blocked by: #31987 and #32470
Related to: #30236
Old Jira task: WM-51
New Jira task for Conn: CONN-273