feat(apps): bridge method for removing users of a room #32706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 05b1159 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
d-gubert
reviewed
Jul 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32706 +/- ##
===========================================
- Coverage 56.72% 56.66% -0.06%
===========================================
Files 2504 2504
Lines 55518 55518
Branches 11440 11440
===========================================
- Hits 31490 31459 -31
- Misses 21341 21370 +29
- Partials 2687 2689 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
changed the title
d-gubert
previously approved these changes
Jul 10, 2024
…/removeUsers * 'develop' of github.com:RocketChat/Rocket.Chat: refactor(omnichannel): replace create and find by findAndUpdate (#32773) chore: Bump apps engine 1.44-alpha (#32774) refactor(client): Remove usage of `React.FC` type (#32760) refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295) refactor(omnichannel): spare few Room.find on requestRoom method (#32363) refactor: `dispatchInquiryPosition` being called multiple times (#32767) fix: SAML "Overwrite user fullname" setting is not being honored (#32628) fix(Omnichannel): Use Correct components on ChatInfo (#32592)
ggazzo
added
the
stat: QA assured
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Implemented bridge method for RocketChat/Rocket.Chat.Apps-engine#776
Issue(s)
CORE-498
Steps to test or reproduce
Further comments