Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sidebar new components #32821

Merged
merged 7 commits into from
Sep 6, 2024
Merged

feat: Sidebar new components #32821

merged 7 commits into from
Sep 6, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Jul 17, 2024

Proposed changes (including videos or screenshots)

  • replace new SidebarV2 components from fuselage
  • refactor apps/meteor/client/sidebarv2/RoomList/RoomList.tsx with GroupedVirtuoso component

These changes only affect the feature preview newNavigation - when Enhanced navigation experience is enabled

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: afb646c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/uikit-playground Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-theming Minor
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-composer Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/meteor Minor
@rocket.chat/livechat Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.34%. Comparing base (532f088) to head (c8421a8).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32821      +/-   ##
===========================================
+ Coverage    59.32%   59.34%   +0.01%     
===========================================
  Files         2547     2549       +2     
  Lines        63346    63376      +30     
  Branches     14254    14257       +3     
===========================================
+ Hits         37581    37611      +30     
  Misses       23062    23062              
  Partials      2703     2703              
Flag Coverage Δ
unit 75.27% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti force-pushed the feat/navigation-phase-3 branch 2 times, most recently from f9d1ce6 to df70c06 Compare July 18, 2024 20:51
@juliajforesti juliajforesti force-pushed the feat/navigation-phase-3 branch 3 times, most recently from 0670423 to 3dcfaaa Compare August 8, 2024 19:28
@juliajforesti juliajforesti changed the title feat: Sidepanel navigation feat: SideBar new components Sep 5, 2024
@juliajforesti juliajforesti marked this pull request as ready for review September 6, 2024 15:29
@juliajforesti juliajforesti requested a review from a team as a code owner September 6, 2024 15:29
@juliajforesti juliajforesti changed the title feat: SideBar new components feat: Sidebar new components Sep 6, 2024
@ggazzo ggazzo added this to the 6.13 milestone Sep 6, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 6, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 6, 2024
@ggazzo ggazzo merged commit cd0d500 into develop Sep 6, 2024
8 of 32 checks passed
@ggazzo ggazzo deleted the feat/navigation-phase-3 branch September 6, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants