fix: Create discussion form Create button is disabled when starting discussion from message

.changeset/perfect-coins-camp.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": patch
+---
+
+fixed an issue in the "Create discussion" form, that would have the "Create" action button disabled even though the form is prefilled when opening it from the message action

apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx

@@ -46,11 +46,10 @@ const CreateDiscussion = ({ onClose, defaultParentRoom, parentMessageId, nameSug
 	const t = useTranslation();
 
 	const {
-		formState: { isDirty, isSubmitting, isValidating, errors },
+		formState: { isSubmitting, isValidating, errors },
 		handleSubmit,
 		control,
 		watch,
-		register,
 	} = useForm({
 		mode: 'onBlur',
 		defaultValues: {
@@ -175,7 +174,11 @@ const CreateDiscussion = ({ onClose, defaultParentRoom, parentMessageId, nameSug
 					<Field>
 						<FieldLabel htmlFor={topicId}>{t('Topic')}</FieldLabel>
 						<FieldRow>
-							<TextInput id={topicId} aria-describedby={`${topicId}-hint`} {...register('topic')} />
+							<Controller
+								name='topic'
+								control={control}
+								render={({ field }) => <TextInput id={topicId} {...field} aria-describedby={`${topicId}-hint`} />}
+							/>
 						</FieldRow>
 						<FieldRow>
 							<FieldHint id={`${topicId}-hint`}>{t('Displayed_next_to_name')}</FieldHint>
@@ -243,7 +246,7 @@ const CreateDiscussion = ({ onClose, defaultParentRoom, parentMessageId, nameSug
 			<Modal.Footer>
 				<Modal.FooterControllers>
 					<Button onClick={onClose}>{t('Cancel')}</Button>
-					<Button type='submit' primary disabled={!isDirty} loading={isSubmitting || isValidating}>
+					<Button type='submit' primary loading={isSubmitting || isValidating}>
 						{t('Create')}
 					</Button>
 				</Modal.FooterControllers>

apps/meteor/tests/e2e/message-actions.spec.ts

@@ -76,11 +76,10 @@ test.describe.serial('message-actions', () => {
 		await poHomeChannel.content.sendMessage(message);
 		await poHomeChannel.content.openLastMessageMenu();
 		await page.locator('role=menuitem[name="Start a Discussion"]').click();
-		await page.locator('input[name="topic"]').fill('1');
-		await page.getByRole('dialog').getByRole('button', { name: 'create' }).click();
-		// There is some condition checking if the form has been edited.
-		// the "Create" button should not be disabled if starting a discussion from a message
-		// TODO: Fix form and remove line below
+		const createButton = page.getByRole('dialog').getByRole('button', { name: 'create' });
+		// Name should be prefilled thus making the create button enabled
+		await expect(createButton).not.toBeDisabled();
+		await createButton.click();
 		await expect(page.locator('header h1')).toHaveText(message);
 	});