Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imported fixes #33142

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: imported fixes #33142

merged 1 commit into from
Aug 26, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Aug 23, 2024

Backport of #33136

@dionisio-bot dionisio-bot bot requested review from a team as code owners August 23, 2024 22:51
@dionisio-bot dionisio-bot bot requested a review from julio-cfa August 23, 2024 22:51
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 8d48d10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Aug 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added backport and removed backport labels Aug 23, 2024
@dionisio-bot dionisio-bot bot mentioned this pull request Aug 23, 2024
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.10.5@4991617). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.5   #33142   +/-   ##
=================================================
  Coverage                  ?   56.61%           
=================================================
  Files                     ?     2504           
  Lines                     ?    55699           
  Branches                  ?    11527           
=================================================
  Hits                      ?    31535           
  Misses                    ?    21466           
  Partials                  ?     2698           
Flag Coverage Δ
e2e 56.50% <ø> (?)
unit 71.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-cfa julio-cfa added stat: QA assured Means it has been tested and approved by a company insider stat: QA tested stat: ready to merge PR tested and approved waiting for merge and removed stat: QA assured Means it has been tested and approved by a company insider stat: QA tested labels Aug 26, 2024
@kodiakhq kodiakhq bot merged commit 103106f into release-6.10.5 Aug 26, 2024
56 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.10.5-33136 branch August 26, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants