-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: markdown inconsistency with bold and italics #33157
Conversation
🦋 Changeset detectedLatest commit: 73c7a7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33157 +/- ##
========================================
Coverage 59.33% 59.33%
========================================
Files 2548 2548
Lines 63320 63320
Branches 14248 14248
========================================
Hits 37570 37570
Misses 23043 23043
Partials 2707 2707
Flags with carried forward coverage won't be shown. Click here to find out more. |
csuarez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This PR solves an inconsistency between the markdown parser used in the composer and the parser used in the rest of the application that was causing different outputs in both sides when using bold and italics.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-537
Steps to test or reproduce
Further comments
related to #32574
Closes #32544
Closes #32081