fix: LivechatSessionTaken webhook event called without agent param

[KevLehman]

Proposed changes (including videos or screenshots)

Basically, the call to assignAgent was updating the room object as expected, but when calling afterTakeInquiry callback we were passing the room before it was updated.

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-654

Steps to test or reproduce

Further comments

I'm planning to spin up a webhook.test docker image to test this one but probably in the future 😬

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 57c126c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.84%. Comparing base (6a3c25c) to head (57c126c).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #33209      +/-   ##
===========================================
- Coverage    59.85%   59.84%   -0.01%     
===========================================
  Files         2554     2554              
  Lines        63008    63105      +97     
  Branches     14129    14146      +17     
===========================================
+ Hits         37711    37766      +55     
- Misses       22890    22924      +34     
- Partials      2407     2415       +8     

Flag	Coverage Δ
unit	77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Is there any way of adding tests? Just saw the description

[sophia-devs]

Can we get an update on this?

stale

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-18 18:25 UTC