Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RoomSidepanel #33225

Merged
merged 14 commits into from
Sep 19, 2024
Merged

feat: RoomSidepanel #33225

merged 14 commits into from
Sep 19, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Sep 6, 2024

  • sort when room changes
  • reactivity after room changes config

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: e3f2772

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/core-services Minor
@rocket.chat/model-typings Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/ui-client Major
@rocket.chat/meteor Minor
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/apps Patch
@rocket.chat/models Patch
@rocket.chat/api-client Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-contexts Major
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo changed the base branch from develop to feat/teams-and-discs September 6, 2024 18:23
@ggazzo ggazzo added this to the 6.13 milestone Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.85%. Comparing base (4033974) to head (e3f2772).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33225   +/-   ##
========================================
  Coverage    59.85%   59.85%           
========================================
  Files         2554     2554           
  Lines        63004    62989   -15     
  Branches     14127    14120    -7     
========================================
- Hits         37708    37701    -7     
+ Misses       22890    22885    -5     
+ Partials      2406     2403    -3     
Flag Coverage Δ
unit 77.15% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 17, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-19 22:24 UTC

Base automatically changed from feat/teams-and-discs to develop September 17, 2024 16:39
@ggazzo ggazzo force-pushed the feat/room-sidepanel branch 9 times, most recently from a5b1597 to 7323802 Compare September 19, 2024 16:53
@ggazzo ggazzo marked this pull request as ready for review September 19, 2024 19:11
@ggazzo ggazzo requested review from a team as code owners September 19, 2024 19:11
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 19, 2024
@kodiakhq kodiakhq bot merged commit 12d6307 into develop Sep 19, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the feat/room-sidepanel branch September 19, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants