Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: imported fixes #33268

Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: imported fixes #33268

merged 1 commit into from
Sep 13, 2024

Conversation

dionisio-bot[bot]
Copy link
Contributor

@dionisio-bot dionisio-bot bot commented Sep 12, 2024

Backport of #33246

@dionisio-bot dionisio-bot bot requested review from a team as code owners September 12, 2024 15:08
Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: 1f82857

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

dionisio-bot bot commented Sep 12, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.71%. Comparing base (ed7398d) to head (1f82857).
Report is 2 commits behind head on release-6.12.1.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.12.1   #33268   +/-   ##
===============================================
  Coverage           58.71%   58.71%           
===============================================
  Files                2682     2682           
  Lines               65009    65011    +2     
  Branches            14603    14603           
===============================================
+ Hits                38167    38169    +2     
  Misses              24366    24366           
  Partials             2476     2476           
Flag Coverage Δ
unit 77.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@julio-cfa julio-cfa added stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 12, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA tested labels Sep 12, 2024
@julio-cfa julio-cfa added the stat: ready to merge PR tested and approved waiting for merge label Sep 12, 2024
@scuciatto scuciatto added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Sep 13, 2024
@kodiakhq kodiakhq bot merged commit 4aeb619 into release-6.12.1 Sep 13, 2024
59 of 60 checks passed
@kodiakhq kodiakhq bot deleted the backport-6.12.1-33246 branch September 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants