Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable message formatter tools for selected text containing newline character #33288

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

abirc8010
Copy link

Proposed changes (including videos or screenshots)

Before:
Before.webm

After:
After.webm

Issue(s)

Steps to test or reproduce

Further comments

This PR disables formatting tools for selected text with newline characters, similar to the behaviour in WhatsApp Web. This prevents unintended formatting issues with multi-line selections and improves consistency and user experience.

@abirc8010 abirc8010 requested a review from a team as a code owner September 15, 2024 13:51
Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: 8b1efd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Sep 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@CLAassistant
Copy link

CLAassistant commented Sep 15, 2024

CLA assistant check
All committers have signed the CLA.

@abirc8010 abirc8010 changed the title feat: Disable message formatter tools for selected text containing newline feat: Disable message formatter tools for selected text containing newline character Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants