[FIX] Send email to admins when user need to be approved to join #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
luisfn
changed the title
| subject: Accounts.emailTemplates.notifyAdmin.subject(), | ||
| html: Accounts.emailTemplates.notifyAdmin.html(user) | ||
| }; | ||
|
|
There was a problem hiding this comment.
Instead of sending an e-mail for each of the admins, I'd make a list of admin emails and send only one e-mail with everyone on it.
One of the advantages to this is knowing who are the other admins that received that email and might have acted on it before you do.
|
@luisfn This looked pretty awesome, why did you close? |
|
Yes, I moved to #7098. Hope it's in the right path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #976
The idea is to send a simple email to all admin users when an user register and needs approval to join.