[NEW] Makes shield icon configurable #9746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
previously requested changes
Feb 16, 2018
There was a problem hiding this comment.
Ideally we want to keep it so a user never edits the local files. It should be possible in the UI. We have many cases where the filesystem Rocket.Chat is on is read only.
My suggestion would be to change it to actually make use of the svg icon that can be uploaded in assets: a
That way will make use of the very same icon used as favicon.
|
@geekgonecrazy should there be a separate icon called shield in the assets ui or the favicon icon itself be used? |
|
In my opinion making use of the same exact icon would be desirable for the end user. Less for them to have to upload and maintain. This way they upload their logo once and its used everywhere its needed. |
|
Made requested changes. |
geekgonecrazy
approved these changes
Feb 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RocketChat/core
Closes #6989
This pr makes the shield icon in the shield.svg api route configurable. Desired svg image can be added in the public/images/shield/shield-icon.svg file to replace the default rocket.chat icon.
Example:
