Statusbar to use _closed_time for elapsed when closed #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
avylove
reviewed
Jun 9, 2024
| @@ -163,7 +163,7 @@ class PrintableCounter(BaseCounter): # pylint: disable=too-many-instance-attrib | |||
| Base class for printable counters | |||
| """ | |||
|
|
|||
| __slots__ = ('_closed', '_count_updated', 'enabled', '_fill', 'last_update', | |||
| __slots__ = ('_closed', '_closed_time', '_count_updated', 'enabled', '_fill', 'last_update', | |||
There was a problem hiding this comment.
I'm hesitant to add another variable when _count_updated is already available. It could be renamed to be more general purpose.
| @@ -180,6 +180,7 @@ def __init__(self, keywords=None, **kwargs): | |||
| self.min_delta = kwargs.pop('min_delta', 0.1) | |||
| self._pinned = False | |||
| self.last_update = self.start = self._count_updated = time.time() | |||
| self._closed_time = None | |||
There was a problem hiding this comment.
I don't like that the type changes here. If it's going to be a float, it should probably start with the value 0.0.
| @@ -272,6 +273,8 @@ def close(self, clear=False): | |||
| elif self in self.manager.counters: | |||
| self.refresh() | |||
|
|
|||
| self._closed_time = time.time() - self.start | |||
There was a problem hiding this comment.
You're calculating elapsed time here and putting it in the closed time variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A preliminary fix for issue #66 , at least it fixes my symptoms.