Replace lazy_static! macro with once_cell #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Jan 27, 2020
vm/src/vm.rs
Outdated
| lazy_static! { | ||
| static ref REPR_GUARDS: Mutex<HashSet<usize>> = { Mutex::new(HashSet::new()) }; | ||
| } | ||
| static REPR_GUARDS: Lazy<Mutex<HashSet<usize>>> = Lazy::new(|| Mutex::new(HashSet::new())); |
There was a problem hiding this comment.
Could this be Lazy::default()?
There was a problem hiding this comment.
Unfortunately I don't think so. I don't see anything like that documented and throws a compile error
There was a problem hiding this comment.
Really? It looks like Default is implemented for Lazy<T: Default> here.
There was a problem hiding this comment.
Oh, maybe it's not a const fn. Could do Lazy::new(Mutex::default), though.
There was a problem hiding this comment.
Yup, that's it. But the latter strategy works
dralley
force-pushed
the
once-cell
branch
4 times, most recently
from
33fe2c7
to
42c521c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
once_cellis generally considered to be superior tolazy_staticnowadays since it doesn't require a macro and has some extra flexibility. The ongoing proposal to add lazy initialization to the stdlib basically copies theonce_cellAPI.rust-lang-nursery/lazy-static.rs#111
rust-lang/rfcs#2788