Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhance] Add support for dict input in Choice #138

Merged
merged 10 commits into from
Jan 18, 2023
Merged

[Enhance] Add support for dict input in Choice #138

merged 10 commits into from
Jan 18, 2023

Conversation

KKIEEK
Copy link
Contributor

@KKIEEK KKIEEK commented Jan 17, 2023

Usage

some = dict(
    type='Choice',
    categories=dict(
        alias1=complicated_obj1,
        alias2=complicated_obj2))

# It is equivalent to the above
some = dict(
    type='Choice',
    categories=[complicated_obj1, complicated_obj2],
    alias=['alias1', 'alias2']))

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@528eacc). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage        ?   62.59%           
=======================================
  Files           ?       63           
  Lines           ?     2016           
  Branches        ?      314           
=======================================
  Hits            ?     1262           
  Misses          ?      650           
  Partials        ?      104           
Flag Coverage Δ
unittests 62.59% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KKIEEK KKIEEK requested review from yhna940 and nijkah January 17, 2023 16:04
@KKIEEK KKIEEK changed the title [Enhancement] Add support for dict input in Choice [Enhance] Add support for dict input in Choice Jan 17, 2023
Co-authored-by: YH <100389977+yhna940@users.noreply.github.com>
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
@KKIEEK KKIEEK requested a review from yhna940 January 18, 2023 01:07
KKIEEK and others added 5 commits January 18, 2023 10:58
Co-authored-by: Hakjin Lee <nijkah@gmail.com>
Signed-off-by: Junhwa Song <ethan9867@gmail.com>
@nijkah nijkah self-requested a review January 18, 2023 02:16
@KKIEEK KKIEEK merged commit b7385cb into main Jan 18, 2023
@KKIEEK KKIEEK deleted the enhance/choice branch January 18, 2023 02:36
@KKIEEK KKIEEK mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants