Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

admin/log-the-spreadsheets #40

Merged
merged 3 commits into from
Sep 17, 2021
Merged

admin/log-the-spreadsheets #40

merged 3 commits into from
Sep 17, 2021

Conversation

tohuynh
Copy link
Contributor

@tohuynh tohuynh commented Sep 17, 2021

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [feature/add-link-checker #12], adds tiff file format support
  • Provide context of changes.
    Log the db.find method.
    As a final task to the data pipeline, log the spreadsheets that were loaded.
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@tohuynh tohuynh merged commit 1e0c1bf into master Sep 17, 2021
@tohuynh tohuynh deleted the admin/log-the-spreadsheets branch September 17, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant