Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/remove-token-and-add-write-permission #56

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

tohuynh
Copy link
Contributor

@tohuynh tohuynh commented Oct 15, 2023

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [feature/add-link-checker #12], adds tiff file format support
  • Provide context of changes.
  • Got ```remote: Invalid username or password.
    fatal: Authentication failed for 'https://github.com/SIGLA-GU/siglatools.git/'`` error for the publish doc workflow.
  • Remove the token specification and add write permission: https://github.com/marketplace/actions/deploy-to-github-pages
  • Relevant doc: If you do not supply the action with an access token or an SSH key, you must access your repositories settings and provide Read and Write Permissions to the provided GITHUB_TOKEN, otherwise you'll potentially run into permission issues. Alternatively you can set the following in your workflow file to grant the action the permissions it needs. permissions: contents: write
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@tohuynh tohuynh merged commit 5594a45 into master Oct 15, 2023
4 checks passed
@tohuynh tohuynh deleted the fix/publish-docs branch October 15, 2023 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant