Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/add-specific-error-info #57

Merged
merged 6 commits into from
Oct 15, 2023
Merged

feat/add-specific-error-info #57

merged 6 commits into from
Oct 15, 2023

Conversation

tohuynh
Copy link
Contributor

@tohuynh tohuynh commented Oct 15, 2023

Pull request recommendations:

  • Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
  • Link to any relevant issue in the PR description. Ex: Resolves [feature/add-link-checker #12], adds tiff file format support
  • Provide context of changes.
  • Add more info to error msgs:
  • country to UnableToFindDocument error
  • sheet id to a1 notation errors
  • Remove write to sys err for errors
  • Provide relevant tests for your feature or bug fix.
  • Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

@tohuynh tohuynh merged commit c5e0147 into master Oct 15, 2023
4 checks passed
@tohuynh tohuynh deleted the feat/country-in-error-msg branch October 15, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tohuynh