Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail_fast should still make update-deps task fail #112

Closed
CasperWA opened this issue Mar 6, 2023 · 0 comments · Fixed by #109
Closed

fail_fast should still make update-deps task fail #112

CasperWA opened this issue Mar 6, 2023 · 0 comments · Fixed by #109
Assignees
@CasperWA
Labels
bug Something isn't working GH Workflows Issue/PR related to the callable workflows

Comments

@CasperWA
Copy link
Collaborator

CasperWA commented Mar 6, 2023

Currently, fail_fast just skips erroring in certain cases, but it should always ensure an error is raised and pyproject.toml is not updated. I.e., the update-deps task should be "atomic".
@CasperWA CasperWA added bug Something isn't working pre-commit hooks Issue/PR related to pre-commit hooks labels Mar 6, 2023
@CasperWA CasperWA self-assigned this Mar 6, 2023
@CasperWA CasperWA added GH Workflows Issue/PR related to the callable workflows and removed pre-commit hooks Issue/PR related to pre-commit hooks labels Mar 6, 2023
@CasperWA CasperWA mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working GH Workflows Issue/PR related to the callable workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Python API SINTEF/ci-cd
1 participant
@CasperWA