Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python API #109

Merged
merged 7 commits into from
Mar 7, 2023
Merged

Update Python API #109

merged 7 commits into from
Mar 7, 2023

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Mar 6, 2023

Part 1 of closing #95.

Update the Python API; split out the individual task functions to separate files/modules, where task-specific utility functions can be added as well.

This only "true" changes here belongs to the last commit; fc56da1, which ensures fail_fast works as intended. This was necessary to satisfy mypy (and also fix that issue, really).

Note, this is part 1 of 3 of a new set of PRs that replace #99.

Closes #112

@CasperWA CasperWA changed the title Update Python api Update Python API Mar 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #109 (2046157) into main (2e0929c) will increase coverage by 3.91%.
The diff coverage is 57.74%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   53.69%   57.61%   +3.91%     
==========================================
  Files           3        8       +5     
  Lines         311      361      +50     
==========================================
+ Hits          167      208      +41     
- Misses        144      153       +9     
Impacted Files Coverage Δ
ci_cd/tasks/docs_index.py 23.33% <23.33%> (ø)
ci_cd/tasks/setver.py 23.52% <23.52%> (ø)
ci_cd/tasks/api_reference_docs.py 65.41% <65.41%> (ø)
ci_cd/tasks/update_deps.py 68.81% <68.81%> (ø)
ci_cd/utils.py 69.76% <69.76%> (ø)
ci_cd/tasks/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@CasperWA CasperWA merged commit 17037f9 into main Mar 7, 2023
@CasperWA CasperWA deleted the cwa/update-python-api branch March 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fail_fast should still make update-deps task fail
3 participants