Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for checking documentation framework #153

Merged
merged 1 commit into from
May 23, 2023

Conversation

CasperWA
Copy link
Collaborator

Fixes #152

I started out creating a separate bash script to call for these checks. In that way it was possible to unit test the bash parts run in the workflow.
However, it turned out to be quite overkill for what's needed, så instead I fixed the immediate issue and attempted to search for more.

In the end, it might still be nice to have a separate bash script - or even implement utility tools into the Python ci-cd package - to call and have separate unit tests for to ensure it all works as intended.

@CasperWA CasperWA requested a review from Treesarj May 18, 2023 15:16
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #153 (c8ebff5) into main (5987a04) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files           9        9           
  Lines         472      472           
=======================================
  Hits          310      310           
  Misses        162      162           

@CasperWA CasperWA enabled auto-merge (squash) May 23, 2023 11:17
@CasperWA CasperWA merged commit 7907901 into main May 23, 2023
@CasperWA CasperWA deleted the cwa/fix-152-input-check-logic branch May 23, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flawed logic
2 participants