Parse pylint_options depending on newlines
#170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch has been used and tested in the OPTIMADE Gateway repository, see this workflow run. Furthermore, I have tested the solution for parsing a single line locally with great success. |
Codecov Report
@@ Coverage Diff @@
## main #170 +/- ##
=======================================
Coverage 71.42% 71.42%
=======================================
Files 9 9
Lines 567 567
=======================================
Hits 405 405
Misses 162 162 |
|
This check should be included for all other input values that allows both single line and multi-line inputs. |
If it not accepted: Remove the mention of single line in the description of the input, leaving only "multi-line". And always parse as if it is a multi-line input. If it is accepted: Update the parsing to check for newline characters before actually parsing the input. Also add "(space-separated)" to describe a multi-valued single-line input.
francescalb
reviewed
Aug 29, 2023
A new section "General information" has been added in the documentation under the overview of the workflows. A section about single vs multi-line values have been added, including examples. This section has then been referenced throughout the documentation for specific input parameters that mention "single og multi-line values".
|
So I added the examples from the comment to the documentation. I did so under a new "General information" section in the overview page of the workflows (see below). I've also referenced this new section in the descriptions of the individual input parameters that mention "single or multi-line strings".
|
francescalb
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #169
Check whether a newline character (
\n) exists in the given variable and parse it accordingly.