Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes prior to auto-merge #88

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Dec 6, 2022

Closes #69

Make it possible to perform changes prior to activating auto-merging during the auto-merging workflow.

Make it possible to perform changes prior to activating auto-merging
during the auto-merging workflow.
@codecov-commenter
Copy link

Codecov Report

Merging #88 (f14de82) into main (0991d57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #88   +/-   ##
=======================================
  Coverage   53.69%   53.69%           
=======================================
  Files           3        3           
  Lines         311      311           
=======================================
  Hits          167      167           
  Misses        144      144           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, I guess the real test if the documentation is good enough is when these examples need to be adapted to a repo using the ci/cd. I suggest that you make sure someone else than you make such changes for a while now, to really see if the rest of the team is able to make use of this in a good manner.

@CasperWA
Copy link
Collaborator Author

CasperWA commented Dec 7, 2022

Looks fine, I guess the real test if the documentation is good enough is when these examples need to be adapted to a repo using the ci/cd. (...)

This is already being used in many of our repositories.

Are you suggesting we have examples for each repository that uses ci-cd?

@CasperWA CasperWA merged commit 1a35c8c into main Dec 7, 2022
@CasperWA CasperWA deleted the cwa/close-69-changes-in-automerge-workflow branch December 7, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend "automerge" workflow with changes
3 participants