Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Istio: Adding Traffic Management tests #1334

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmnelemane
Copy link
Contributor

Why is this PR needed?

Does it fix an issue? addresses a business case?

add a description and link to the issue if one exists.

Fixes #

Reminder: Add the "fixes bsc#XXXX" to the title of the commit so that it will
appear in the changelog.

What does this PR do?

please include a brief "management" technical overview (details are in the code)

Anything else a reviewer needs to know?

Special test cases, manual steps, links to resources or anything else that could be helpful to the reviewer.

Info for QA

This is info for QA so that they can validate this. This is mandatory if this PR fixes a bug.
If this is a new feature, a good description in "What does this PR do" may be enough.

Related info

Info that can be relevant for QA:

  • link to other PRs that should be merged together
  • link to packages that should be released together
  • upstream issues

Status BEFORE applying the patch

How can we reproduce the issue? How can we see this issue? Please provide the steps and the prove
this issue is not fixed.

Status AFTER applying the patch

How can we validate this issue is fixed? Please provide the steps and the prove this issue is fixed.

Docs

If docs need to be updated, please add a link to a PR to https://github.com/SUSE/doc-caasp.
At the time of creating the issue, this PR can be work in progress (set its title to [WIP]),
but the documentation needs to be finalized before the PR can be merged.

Merge restrictions

(Please do not edit this)

We are in v4-maintenance phase, so we will restrict what can be merged to prevent unexpected surprises:

What can be merged (merge criteria):
    2 approvals:
        1 developer: code is fine
        1 QA: QA is fine
    there is a PR for updating documentation (or a statement that this is not needed)

@mmnelemane mmnelemane added the wip label Aug 20, 2020
@mmnelemane mmnelemane self-assigned this Aug 20, 2020
@mmnelemane mmnelemane added this to the 4.2.1 milestone Aug 20, 2020
@mmnelemane mmnelemane force-pushed the istio-test branch 2 times, most recently from 47e72cc to ca4ab6e Compare August 20, 2020 10:32
@Itxaka
Copy link
Contributor

Itxaka commented Nov 10, 2020

is this still valid @mmnelemane? has networking reviewed it @mbologna ?

It still needs an update...and it should be fast otherwise we should just close it.

@mmnelemane
Copy link
Contributor Author

@Itxaka A simplified test was included in Skuba and since there was no plan to include Istio in the CaaSP release, I stopped this expansion. I think it can be closed for now unless someone still requests for Istio on CaaSP 4.5.

@mmnelemane mmnelemane closed this Nov 10, 2020
@mmnelemane
Copy link
Contributor Author

I would let the branch stay, so that we can use it if needed in future.

@mmnelemane mmnelemane reopened this Nov 10, 2020
@Itxaka
Copy link
Contributor

Itxaka commented Nov 10, 2020

Thanks for the update @mmnelemane Closing the Pr does not remove the branch btw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants