Bugfix: Function called on empty dataset (#3673)

fixes #3672
SatcherInstitute · Sep 17, 2024 · f6bcfd3 · f6bcfd3
1 parent b711482
commit f6bcfd3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/frontend/src/cards/SimpleBarChartCard.tsx b/frontend/src/cards/SimpleBarChartCard.tsx
@@ -31,10 +31,7 @@ import type { ElementHashIdHiddenOnScreenshot } from '../utils/hooks/useDownload
 import { GUN_VIOLENCE_DATATYPES } from '../data/providers/GunViolenceProvider'
 import LawEnforcementAlert from './ui/LawEnforcementAlert'
 import { isPctType } from '../data/config/MetricConfigUtils'
-import {
-  addComparisonAllsRowToIntersectionalData,
-  specialAllGroup,
-} from '../charts/simpleBarHelperFunctions'
+import { addComparisonAllsRowToIntersectionalData } from '../charts/simpleBarHelperFunctions'
 
 /* minimize layout shift */
 const PRELOAD_HEIGHT = 668

diff --git a/frontend/src/charts/simpleBarHelperFunctions.ts b/frontend/src/charts/simpleBarHelperFunctions.ts
@@ -308,7 +308,7 @@ export function addComparisonAllsRowToIntersectionalData(
   rateQueryResponseRateAlls: MetricQueryResponse,
 ) {
   // rename intersectional 'All' group
-  const dataWithAllsRow = data.map((row) => {
+  const adjustedData = data.map((row) => {
     const renameRow = { ...row }
     if (row[demographicType] === specialAllGroup) {
       renameRow[demographicType] = rateComparisonConfig?.shortLabel
@@ -317,7 +317,12 @@ export function addComparisonAllsRowToIntersectionalData(
   })
 
   // add the comparison ALLs row to the intersectional data
-  const originalAllsRow = rateQueryResponseRateAlls.data[0]
+  const originalAllsRow = rateQueryResponseRateAlls?.data?.[0]
+
+  if (!originalAllsRow) {
+    return adjustedData
+  }
+
   const { fips, fips_name } = originalAllsRow
 
   const allsRow = {
@@ -327,7 +332,7 @@ export function addComparisonAllsRowToIntersectionalData(
     [rateConfig.metricId]:
       originalAllsRow[rateConfig?.rateComparisonMetricForAlls?.metricId ?? ''],
   }
-  dataWithAllsRow.unshift(allsRow)
+  adjustedData.unshift(allsRow)
 
-  return dataWithAllsRow
+  return adjustedData
 }