Fix warnings dataset utils #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for health-equity-tracker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ity-tracker into fix-warnings-dataset-utils
benhammondmusic
force-pushed
the
fix-warnings-dataset-utils
branch
from
d07c234
to
4c3a8f6
Compare
eriwarr
approved these changes
Aug 28, 2024
kccrtv
pushed a commit
to kccrtv/health-equity-tracker
that referenced
this pull request
Aug 29, 2024
# Description and Motivation <!--- bulleted, high level items. use keywords (eg "closes SatcherInstitute#144" or "fixes #4323") --> - adjust loading utility to cast `None` as `np.nan` using the Pandas 3 "no silent downcasting" behavior - adjust remaining tests to expect `np.nan` for missing data NOTE: we should aim to always use `np.nan` to represent missing Pandas DF data, and reserve `None` for Python things like undefined args, etc. ## Has this been tested? How? - tests pass - no more future warnings from these test files ## Types of changes (leave all that apply) - Future Bug fix ## New frontend preview link is below in the Netlify comment 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Motivation
Noneasnp.nanusing the Pandas 3 "no silent downcasting" behaviornp.nanfor missing dataNOTE: we should aim to always use
np.nanto represent missing Pandas DF data, and reserveNonefor Python things like undefined args, etc.Has this been tested? How?
Types of changes
(leave all that apply)
New frontend preview link is below in the Netlify comment 😎