Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides empty time cards #3628

Merged

Conversation

benhammondmusic
Copy link
Collaborator

@benhammondmusic benhammondmusic commented Sep 6, 2024

Description and Motivation

closes #3590

Age Adjusted

  • removes optional boolean indicating age-adjusted ratios, and instead just detects the presence of the age_adjusted_ratio object in the metricConfig
  • rounds age adjusted ratios to a single decimal place

Time Series

  • changes isMonthly boolean used for COVID topics to instead be optional timeSeriesCadence that can by yearly or monthly
  • use the presence of either yearly/monthly to trigger the showing of rates over time card(s)
  • use the presence of pct_relative_inequity metric objects to trigger the showing of inequity over time card(s)

Other

Has this been tested? How?

tests passing

Screenshots (if appropriate)

Screenshot 2024-09-05 at 5 44 27 PM Screenshot 2024-09-05 at 5 44 39 PM Screenshot 2024-09-05 at 5 45 07 PM Screenshot 2024-09-05 at 6 08 07 PM

Types of changes

(leave all that apply)

  • New content or feature
  • Refactor / chore

New frontend preview link is below in the Netlify comment 😎

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for health-equity-tracker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d49009d
🔍 Latest deploy log https://app.netlify.com/sites/health-equity-tracker/deploys/66da7757d559c60008fdd53e
😎 Deploy Preview https://deploy-preview-3628--health-equity-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@benhammondmusic benhammondmusic marked this pull request as ready for review September 6, 2024 03:29
@benhammondmusic benhammondmusic merged commit d769dcb into SatcherInstitute:main Sep 6, 2024
10 checks passed
@benhammondmusic benhammondmusic deleted the hide-empty-cards branch September 6, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should hide cards if the data isn't available/applicable
2 participants