Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove literal_getproperty adjoint from SciMLBase #701

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Now that SciML/SciMLSensitivity.jl#1056 has been merged, this adjoint can be removed from here.

Add any other context about the problem here.

@DhairyaLGandhi DhairyaLGandhi changed the title chore: rm literal_getproperty adjoint Remove literal_getproperty adjoint from SciMLBase May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.53%. Comparing base (de51914) to head (e1bce73).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #701       +/-   ##
===========================================
+ Coverage   28.90%   41.53%   +12.62%     
===========================================
  Files          55       55               
  Lines        4573     4582        +9     
===========================================
+ Hits         1322     1903      +581     
+ Misses       3251     2679      -572     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 9185795 into SciML:master Jun 3, 2024
77 of 124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants