Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge karthik-devel branch #46

Merged
merged 30 commits into from
May 31, 2024
Merged

Merge karthik-devel branch #46

merged 30 commits into from
May 31, 2024

Conversation

kvenkman
Copy link
Contributor

Initial draft of lesson markdown files in spanish, along with other clean up.

Adding .gitignore and an initial draft of the disturbance notebook as well.

@kvenkman kvenkman self-assigned this May 24, 2024
@kvenkman kvenkman requested review from dhavide and jmunroe May 24, 2024 06:14
Copy link
Member

@jnywong jnywong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two main things:

  1. I could not run book/3_Retrieving_Disturbance_Data.py because the dist_utils package was missing from the environment.
  2. I could not run the last part of book/3_Retrieving_FloodData.py, perhaps because the catalog search returns the TIFF images in a OPERA_L3_DSWX-HLS_PROVISIONAL_V1 folder instead of OPERA_L3_DSWX-HLS_V1.

The rest of my review concerns minor formatting suggestions, including software pacakges in the conda environment.yml file, or updating the _toc.yml file of the Jupyter Book.

book/0_Configuracion_inicial.md Outdated Show resolved Hide resolved
book/0_Configuracion_inicial.md Outdated Show resolved Hide resolved
book/0_Initial_Setup.md Outdated Show resolved Hide resolved
book/0_Initial_Setup.md Outdated Show resolved Hide resolved
Comment on lines 9 to 15
# Initial Configuration Steps for 2i2c Hub and EarthData NASA Access

## 1. Accessing the 2i2c Hub

To access the 2i2c Hub, follow these simple steps:

* Go to the 2i2c Hub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Initial Configuration Steps for 2i2c Hub and EarthData NASA Access
## 1. Accessing the 2i2c Hub
To access the 2i2c Hub, follow these simple steps:
* Go to the 2i2c Hub.

This is duplicate information.

@@ -14,7 +14,7 @@

# ## Retrieving OPERA DSWx-HLS data for a flood event
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ## Retrieving OPERA DSWx-HLS data for a flood event
# # Retrieving OPERA DSWx-HLS data for a flood event

@@ -14,7 +14,7 @@

# ## Retrieving OPERA DSWx-HLS data for a flood event
#
# Heavy rains severly impacted Argentina in March 2024 [[1]](https://www.reuters.com/world/americas/argentina-downpour-drenches-crop-fields-flash-floods-buenos-aires-2024-03-12/). The event resulted in flash floods and impacted crop yields, severely impacting the Buenos Aires metropolitan area, and caused significant damage to property and human life. In this notebook, we will retrieve OPERA DSWx-HLS data associated to understand the extent of flooding and damage, and compare data from before and after the event.
# Heavy rains severly impacted Argentina in March 2024 [[1]](https://www.reuters.com/world/americas/argentina-downpour-drenches-crop-fields-flash-floods-buenos-aires-2024-03-12/). The event resulted in flash floods and impacted crop yields, severely impacting the Buenos Aires metropolitan area, and caused significant damage to property and human life. In this notebook, we will retrieve [OPERA DSWx-HLS](https://d2pn8kiwq2w21t.cloudfront.net/documents/ProductSpec_DSWX_URS309746.pdf) data associated to understand the extent of flooding and damage, and compare data from before and after the event.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Heavy rains severly impacted Argentina in March 2024 [[1]](https://www.reuters.com/world/americas/argentina-downpour-drenches-crop-fields-flash-floods-buenos-aires-2024-03-12/). The event resulted in flash floods and impacted crop yields, severely impacting the Buenos Aires metropolitan area, and caused significant damage to property and human life. In this notebook, we will retrieve [OPERA DSWx-HLS](https://d2pn8kiwq2w21t.cloudfront.net/documents/ProductSpec_DSWX_URS309746.pdf) data associated to understand the extent of flooding and damage, and compare data from before and after the event.
# Heavy rains severely impacted Argentina in March 2024 [[1]](https://www.reuters.com/world/americas/argentina-downpour-drenches-crop-fields-flash-floods-buenos-aires-2024-03-12/). The event resulted in flash floods and impacted crop yields, severely impacting the Buenos Aires metropolitan area, and caused significant damage to property and human life. In this notebook, we will retrieve the associated [OPERA DSWx-HLS](https://d2pn8kiwq2w21t.cloudfront.net/documents/ProductSpec_DSWX_URS309746.pdf) data to understand the extent of flooding and damage, and compare data from before and after the event.

@@ -79,7 +79,7 @@
# Setup PySTAC client
provider_cat = Client.open(STAC_URL)
catalog = Client.open(f'{STAC_URL}/POCLOUD/')
collections = ["OPERA_L3_DSWX-HLS_PROVISIONAL_V1"]
collections = ["OPERA_L3_DSWX-HLS_V1"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 for finding this bug!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I get an error later on at line 200 because the search returns references to the OPERA_L3_DSWX-HLS_PROVISIONAL_V1 for the TIFF files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


- To access the data used in this course, you will need a free NASA EarthData user account. You can create an account on the NASA EarthData website ([https://urs.earthdata.nasa.gov/ ](https://urs.earthdata.nasa.gov/)).
- To run the course notebooks, you will need a free 2i2c hub account. You can create an account on the 2i2c website (Link).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorization for the hub is controlled by membership of the ScienceCore GitHub Organization, so I recommend you encourage learners to contact the hub administrator for ScienceCore here.


- To download the course source code, you will need a free user account on GitHub. You can create an account on the GitHub website (<https://github.com/>).
* **Basic Python programming knowledge with focus in data analysis.**
Since the course involves data manipulation and the use of code for spatial analysis, some experience with Python programming is required, particularly for data analysis. The course utilizes specialized Python libraries for working with spatial data. While not mandatory, familiarity with libraries like pandas (data analysis), geopandas (geographic data), or rasterio (reading/writing raster data) can be helpful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since the course involves data manipulation and the use of code for spatial analysis, some experience with Python programming is required, particularly for data analysis. The course utilizes specialized Python libraries for working with spatial data. While not mandatory, familiarity with libraries like pandas (data analysis), geopandas (geographic data), or rasterio (reading/writing raster data) can be helpful.
Since the course involves data manipulation and the use of code for spatial analysis, some experience with Python programming is required, particularly for data analysis. The course utilizes specialized Python libraries for working with spatial data. While not mandatory, familiarity with libraries like `pandas` (data analysis), `geopandas` (geographic data), or `rasterio` (reading/writing raster data) can be helpful.

Copy link
Contributor

@dhavide dhavide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get these merged so that the directories can be rearranged, see #59

@dhavide dhavide merged commit 2706958 into main May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants