Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drawpile: Add version 2.2.1 #13511

Merged
merged 5 commits into from
Jun 26, 2024
Merged

drawpile: Add version 2.2.1 #13511

merged 5 commits into from
Jun 26, 2024

Conversation

chipsTM
Copy link
Contributor

@chipsTM chipsTM commented Jun 24, 2024

Add manifest for Drawpile, a collaborative drawing program that lets multiple people draw, sketch, paint and animate on the same canvas simultaneously.

Closes #13510

Copy link
Contributor

Your changes do not pass checks.

drawpile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Collaborator

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Point github link in checkver directly (since homepage is not GH url).
  • Remove hash section from autoupdate (since there are no corresponding sha256 files in release assets).
  • CRLF EOL.

}
},
"bin": "drawpile.exe",
"checkver": "github",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"checkver": "github",
"checkver": {
"github": "https://github.com/drawpile/Drawpile"
},

"extract_dir": "Drawpile-2.2.1-32bit"
}
},
"bin": "drawpile.exe",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bin": "drawpile.exe",
"shortcuts": [
[
"drawpile.exe",
"Drawpile "
]
],

Comment on lines 30 to 34
},
"hash": {
"mode": "extract",
"url": "$url.sha256"
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
},
"hash": {
"mode": "extract",
"url": "$url.sha256"
}
}

"url": "$url.sha256"
}
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@@ -0,0 +1,36 @@
{
"version": "2.2.1",
"description": "Drawpile is a drawing program that lets you draw, paint and animate together with others on the same canvas. It runs on Windows, Linux, macOS and Android.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Drawpile is a drawing program that lets you draw, paint and animate together with others on the same canvas. It runs on Windows, Linux, macOS and Android.",
"description": "A drawing program that lets you draw, paint and animate together with others on the same canvas",

@chipsTM
Copy link
Contributor Author

chipsTM commented Jun 25, 2024

/verify

thanks for the suggestions

Copy link
Contributor

Your changes do not pass checks.

drawpile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@chipsTM
Copy link
Contributor Author

chipsTM commented Jun 26, 2024

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

drawpile

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@aliesbelik aliesbelik merged commit 027c53b into ScoopInstaller:master Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request]: drawpile
2 participants