Derive value type #1720

darkmmon · 2023-06-23T11:00:29Z

PR Info

Closes Derive macros for custom wrapper types #1349

Dependencies:
- Upgrading to syn v2 #1713 (need to check if syn v2 will break the new macro)

Dependents:

New Features

added macro to derive for simple value type wrapper

Bug Fixes

Breaking Changes

Changes

sea-orm-macros/src/derives/value_type.rs

tyt2y3 · 2023-06-27T16:47:17Z

Looks really good so far!

billy1624

Seems we have 3 more debug messages to "fix"

sea-orm-macros/src/derives/value_type.rs

tests/common/features/custom_wrapper.rs

tyt2y3 · 2023-07-03T22:25:28Z

tests/common/features/value_type.rs

+#[derive(Clone, Debug, PartialEq, Eq, DeriveValueType)]
+#[sea_orm(column_type = "String(Some(1))", array_type = "String")]
+pub struct StringVec(pub Vec<String>);


Great work. I think it looks really good. One question, is array_type required here? What if we omit it?

Can we actually change the test case in tests/common/features/json_vec.rs to use this DeriveValueType instead of the manual implementation?

Just want to make sure we have had end to end tests.

sea-orm-macros/src/derives/value_type.rs

Co-authored-by: 黄景祥 <jingxiang.huang@baishancloud.com>

tyt2y3 · 2023-07-05T19:11:57Z

tests/common/features/value_type.rs

+pub struct Model {
+    #[sea_orm(primary_key)]
+    pub id: i32,
+    pub number: Integer,


The strange bit here is that the StringVec is not included in the Model for testing.
Albeit it only works on Postgres.

May be we can simply change the test case https://github.com/SeaQL/sea-orm/blob/master/tests/common/features/json_vec.rs, because now DeriveValueType is the new, recommended API.

Currently, the conversion of DeriveValueType rely on the pre-defined conversion from the field to Value.
I think Vec<String> currently does not have a defined conversion to any variant of Value, which I suppose it should.
(in json_vec, it convert itself to formatted String as Value, which I suppose isn't a good generic approach)
I'm wondering if I should implement From<Vec<T>> for Value or adjust the DeriveValueType implementation only.

I see. Sadly then it means that we can't 'eat our own dog food' for this test case.

tests/json_vec_tests.rs

tests/common/features/json_vec.rs

tyt2y3 · 2023-07-06T09:46:12Z

So perhaps it's easier to have a separate test case to test StringVec end to end.

This reverts commit 92bbf3b.

tyt2y3

Perfect

billy1624 · 2023-07-07T22:07:40Z

examples/salvo_example/README.md

-# Poem with SeaORM example app
+# Salvo with SeaORM example app


laugh :P
Good eyesight!

billy1624

Thanks!! @darkmmon awesome work!

github-actions · 2023-08-02T17:11:56Z

🎉 Released In 0.12.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

billy1624 assigned darkmmon Jun 26, 2023

billy1624 reviewed Jun 27, 2023

View reviewed changes

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

darkmmon added 10 commits June 28, 2023 10:02

progress (WIP)

5151bc7

WIP

e1f0183

WIP, finished structure except impl programming

ed72c41

WIP

2224121

revert event_trigger modification

a78a995

adding tests and mods

0bca42e

completed derive value type

b612b19

fixed tests, adjusted code position and completed error messages

37dab79

column type commit

4a2219f

added attribute array_type and column_type for specification

bd86566

darkmmon force-pushed the derive_value_type branch from 2b69c2a to bd86566 Compare June 28, 2023 08:47

darkmmon marked this pull request as ready for review June 28, 2023 09:04

billy1624 reviewed Jun 29, 2023

View reviewed changes

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

billy1624 reviewed Jun 29, 2023

View reviewed changes

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

billy1624 reviewed Jun 29, 2023

View reviewed changes

tests/common/features/custom_wrapper.rs Outdated Show resolved Hide resolved

darkmmon added 2 commits June 29, 2023 17:12

renamed items and files, and removed debug messages

c619f26

move attributes outside of the wrapper struct

46e8b36

tyt2y3 reviewed Jul 3, 2023

View reviewed changes

sea-orm-macros/src/derives/value_type.rs Outdated Show resolved Hide resolved

darkmmon and others added 4 commits July 5, 2023 12:17

refactored code for type matching, and restructured code in test cases

db6d57f

clippy fix

588000b

fix(doc): fix salvo framework name (SeaQL#1731)

4620a90

Co-authored-by: 黄景祥 <jingxiang.huang@baishancloud.com>

fmt

12a7808

tyt2y3 reviewed Jul 5, 2023

View reviewed changes

darkmmon added 2 commits July 6, 2023 14:38

changed json_vec_test to use DeriveValueType

92bbf3b

fmt

3e4734f

tyt2y3 reviewed Jul 6, 2023

View reviewed changes

tests/json_vec_tests.rs Outdated Show resolved Hide resolved

tyt2y3 reviewed Jul 6, 2023

View reviewed changes

tests/common/features/json_vec.rs Outdated Show resolved Hide resolved

tyt2y3 reviewed Jul 6, 2023

View reviewed changes

tests/common/features/json_vec.rs Outdated Show resolved Hide resolved

darkmmon added 3 commits July 7, 2023 16:06

Revert "changed json_vec_test to use DeriveValueType"

75dd001

This reverts commit 92bbf3b.

added test cases for inserting StringVec in a model

c663576

fmt

1278f18

tyt2y3 approved these changes Jul 7, 2023

View reviewed changes

billy1624 reviewed Jul 7, 2023

View reviewed changes

examples/salvo_example/README.md Outdated

# Poem with SeaORM example app

# Salvo with SeaORM example app

Copy link

Member

billy1624 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laugh :P
Good eyesight!

billy1624 added 3 commits July 8, 2023 08:19

Try non-public wrapped type

9e3f726

Merge branch 'master' into pr/1720

c3fc4ab

Refactoring

6da5335

billy1624 approved these changes Jul 10, 2023

View reviewed changes

billy1624 merged commit f5a7311 into SeaQL:master Jul 10, 2023
72 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Derive value type #1720

Derive value type #1720

darkmmon commented Jun 23, 2023 •

edited by billy1624

Loading

tyt2y3 commented Jun 27, 2023

billy1624 left a comment

tyt2y3 Jul 3, 2023

tyt2y3 Jul 5, 2023 •

edited

Loading

darkmmon Jul 6, 2023

tyt2y3 Jul 6, 2023

tyt2y3 commented Jul 6, 2023 •

edited

Loading

tyt2y3 left a comment

billy1624 Jul 7, 2023

billy1624 left a comment

github-actions bot commented Aug 2, 2023

		# Poem with SeaORM example app
		# Salvo with SeaORM example app

Derive value type #1720

Derive value type #1720

Conversation

darkmmon commented Jun 23, 2023 • edited by billy1624 Loading

PR Info

New Features

Bug Fixes

Breaking Changes

Changes

tyt2y3 commented Jun 27, 2023

billy1624 left a comment

Choose a reason for hiding this comment

tyt2y3 Jul 3, 2023

Choose a reason for hiding this comment

tyt2y3 Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

darkmmon Jul 6, 2023

Choose a reason for hiding this comment

tyt2y3 Jul 6, 2023

Choose a reason for hiding this comment

tyt2y3 commented Jul 6, 2023 • edited Loading

tyt2y3 left a comment

Choose a reason for hiding this comment

billy1624 Jul 7, 2023

Choose a reason for hiding this comment

billy1624 left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 2, 2023

🎉 Released In 0.12.1 🎉

darkmmon commented Jun 23, 2023 •

edited by billy1624

Loading

tyt2y3 Jul 5, 2023 •

edited

Loading

tyt2y3 commented Jul 6, 2023 •

edited

Loading