Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Identity list regex, safety number interpolation #63

Merged
merged 1 commit into from
May 12, 2021
Merged

Bugfix: Identity list regex, safety number interpolation #63

merged 1 commit into from
May 12, 2021

Conversation

AetherUnbound
Copy link
Collaborator

Resolves #57

This PR fixes two issues:

  1. The regex was failing to match because there were newlines as a result of me making the compliation a docstring.
  2. The interpolation of the safety number into the CLI was failing because of some errant spaces.

mpuckett159
mpuckett159 approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@mpuckett159 mpuckett159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I had a better way to test it but it looks correct and good to me so 🚀

@AetherUnbound AetherUnbound merged commit db9df78 into master May 12, 2021
@AetherUnbound AetherUnbound deleted the bugfix/fix-verify branch May 12, 2021 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpuckett159 mpuckett159 mpuckett159 approved these changes

@ccaarryy ccaarryy Awaiting requested review from ccaarryy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verification utility isn't working
2 participants
@AetherUnbound @mpuckett159