Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: GivensQ <: AbstractQ #4

Open
dkarrasch opened this issue Jan 8, 2023 · 0 comments · May be fixed by #5
Open

Proposal: GivensQ <: AbstractQ #4

dkarrasch opened this issue Jan 8, 2023 · 0 comments · May be fixed by #5

Comments

@dkarrasch
Copy link

I came across this package via a PkgEval run in JuliaLang/julia#46874. I found that currently GivensQ subtypes Factorization, but is actually meant to represent an orthogonal/unitary matrix. So you may want to consider to subtype LinearAlgebra.AbstractQ. After JuliaLang/julia#46196, you could "benefit" from a lot of generic fallbacks that do exactly what you want it to do. You can check the generic part, the beginning of the new file abstractq.jl in that PR, and the added test there to see how it feels and works.
@dkarrasch dkarrasch linked a pull request Feb 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GivensQ subtype AbstractQ, use API dkarrasch/UpdatableQRFactorizations.jl
1 participant
@dkarrasch