Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GivensQ subtype AbstractQ, use API #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dkarrasch
Copy link

This makes this package future-proof for JuliaLang/julia#46196 and JuliaLang/julia#46874. This closes #4. Starting with the AbstractQ API in Julia v1.10, many need not be defined anymore. In fact, eltype promotion is then additionally handled by the fallback.

@SebastianAment
Copy link
Owner

SebastianAment commented Feb 13, 2023

Thank you for putting this up @dkarrasch! The current version fails on Julia 1.6 because this error:

Expression: F.Q \ Qx  x
  MethodError: no method matching lu!(::UpdatableQRFactorizations.GivensQ{Float64, Vector{LinearAlgebra.Givens{Float64}}}, ::Val{true}; check=true)

Is there a more recent stable Julia version or a different fix that would support this?

@dkarrasch
Copy link
Author

Ok, I fixed the issue on v1.6. Unfortunately, switching from Factorization to AbstractQ introduces quite some method ambiguities, which is due to the horrible API for AbstractQ. With the current state of the PR, this packages, however, is ambiguity-free on v1.10. The ambiguities don't show up in the tests because only strided arrays are used, so that usage seems safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: GivensQ <: AbstractQ
2 participants