Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify signature double negation #371

Merged
merged 2 commits into from
Sep 6, 2024
+6 −2
Merged

Fix verify signature double negation #371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d21bdec
Fix verify signature double negation
felixarjuna Sep 6, 2024
d3bea58
Fixed unit test
Secreto31126 Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -976,7 +976,7 @@ export class WhatsAppAPI<EmittersReturnType = void> {
.map((b) => b.toString(16).padStart(2, "0"))
.join("");

return signature !== check;
return signature === check;
}

/**
Expand Down
6 changes: 5 additions & 1 deletion test/index.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,7 +1629,11 @@ describe("WhatsAppAPI", function () {

it("should throw 401 if the signature doesn't match the hash", async function () {
await rejects(
Whatsapp.post(valid_message_mock, body, "wrong"),
Whatsapp.post(
valid_message_mock,
body,
"sha256=wrong"
),
threw(401)
);
});
Expand Down