add functions to extract clause from boolean expressions #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- extractClauseFromBooleanTest() - extractClauseFromBoolExpr() - extractClauseFromVar()
|
After searching a little while, without finding a solution, as to why I was getting 'WARNING: unsupported expression for extractClauseFrom' when trying to filter against a boolean column, I came across this pull request. I applied this patch to 1.4.0 and I can now apply qualifier logic for my boolean column in my python logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now you can't filter some foreign data using the boolean column. I have added several function to
src/query.cto extract data from expressions of this type. I have tested them with all boolean comparison constructions (e.g.is not false,is true,is not unknown), operators (e.g.=,<>) and possible literal values (e.g.'t','yes','off',0,1) and they works well for me.