[build] download pinned selenium manager versions instead of storing …

…in repo
SeleniumHQ · Dec 26, 2023 · 4fd455b · 4fd455b
1 parent 5121d4e
commit 4fd455b
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 24 deletions.
diff --git a/WORKSPACE b/WORKSPACE
@@ -321,6 +321,10 @@ oci_pull(
     repository = "selenium/standalone-chrome",
 )
 
+load("//common:selenium_manager.bzl", "selenium_manager")
+
+selenium_manager()
+
 load("//common:repositories.bzl", "pin_browsers")
 
 pin_browsers()

diff --git a/common/manager/BUILD.bazel b/common/manager/BUILD.bazel
@@ -10,33 +10,15 @@ package(
 
 alias(
     name = "selenium-manager-linux",
-    actual = select({
-        "//common:stamp": "linux/selenium-manager",
-        "//conditions:default": "//rust:selenium-manager-linux",
-    }),
+    actual = "@download_sm_linux//file",
 )
 
 alias(
     name = "selenium-manager-macos",
-    actual = select({
-        "//common:stamp": "macos/selenium-manager",
-        "//conditions:default": "//rust:selenium-manager-macos",
-    }),
+    actual = "@download_sm_macos//file",
 )
 
-# Rust does not compile properly on windows so just use what is in repo for now
 alias(
     name = "selenium-manager-windows",
-    actual = "windows/selenium-manager.exe",
-)
-
-exports_files(
-    [
-        "linux/selenium-manager",
-        "macos/selenium-manager",
-        "windows/selenium-manager.exe",
-    ],
-    visibility = [
-        "//rust:__pkg__",
-    ],
+    actual = "@download_sm_windows//file",
 )
diff --git a/common/manager/linux/selenium-manager b/common/manager/linux/selenium-manager
diff --git a/common/manager/macos/selenium-manager b/common/manager/macos/selenium-manager
diff --git a/common/manager/windows/selenium-manager.exe b/common/manager/windows/selenium-manager.exe
diff --git a/rust/BUILD.bazel b/rust/BUILD.bazel
@@ -18,7 +18,7 @@ alias(
     name = "selenium-manager-windows",
     actual = select({
         "//common:windows": ":selenium-manager",
-        "//conditions:default": "//common/manager:windows/selenium-manager.exe",
+        "//conditions:default": "@download_sm_windows//file",
     }),
     tags = [
         "manual",
@@ -32,7 +32,7 @@ alias(
     name = "selenium-manager-macos",
     actual = select({
         "//common:macos": ":selenium-manager",
-        "//conditions:default": "//common/manager:macos/selenium-manager",
+        "//conditions:default": "@download_sm_macos//file",
     }),
     tags = [
         "manual",
@@ -46,7 +46,7 @@ alias(
     name = "selenium-manager-linux",
     actual = select({
         "//common:linux": ":selenium-manager",
-        "//conditions:default": "//common/manager:linux/selenium-manager",
+        "//conditions:default": "@download_sm_linux//file",
     }),
     tags = [
         "manual",