[JS] Fix stale element test and enable window tests

SeleniumHQ · Apr 17, 2024 · e9ef7e0 · e9ef7e0
1 parent d04cbb5
commit e9ef7e0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/javascript/node/selenium-webdriver/bidi/input.js b/javascript/node/selenium-webdriver/bidi/input.js
@@ -55,9 +55,7 @@ class Input {
       },
     }
 
-    let response = await this.bidi.send(command)
-
-    return response
+    return await this.bidi.send(command)
   }
 
   /**

diff --git a/javascript/node/selenium-webdriver/test/stale_element_test.js b/javascript/node/selenium-webdriver/test/stale_element_test.js
@@ -44,7 +44,7 @@ test.suite(function (env) {
       await driver.wait(until.stalenessOf(toBeDeleted), 5000)
     })
 
-  xit('an element found in a different frame is stale', async function () {
+  it('an element found in a different frame is stale', async function () {
     await driver.get(Pages.missedJsReferencePage)
 
     var frame = await driver.findElement(By.css('iframe[name="inner"]'))
@@ -53,7 +53,7 @@ test.suite(function (env) {
     var el = await driver.findElement(By.id('oneline'))
     await driver.switchTo().defaultContent()
     return el.getText().then(assert.fail, function (e) {
-      assert.ok(e instanceof error.StaleElementReferenceError, `The error is ${JSON.stringify(e)}`)
+      assert.ok(e instanceof error.NoSuchElementError)
     })
   })
 })
diff --git a/javascript/node/selenium-webdriver/test/window_test.js b/javascript/node/selenium-webdriver/test/window_test.js
@@ -75,7 +75,7 @@ test.suite(function (env) {
     assert.strictEqual(await driver.getTitle(), 'We Arrive Here')
   })
 
-  xit('can set the window position of the current window', async function () {
+  it('can set the window position of the current window', async function () {
     let { x, y } = await driver.manage().window().getRect()
     let newX = x + 10
     let newY = y + 10
@@ -90,7 +90,7 @@ test.suite(function (env) {
     await driver.wait(forPositionToBe(newX, newY), 1000)
   })
 
-  xit('can set the window position from a frame', async function () {
+  it('can set the window position from a frame', async function () {
     await driver.get(test.Pages.iframePage)
 
     let frame = await driver.findElement(By.name('iframe1-name'))