refactor(Transition): mountOnEnter -> mountOnShow

Semantic-Org · Jul 26, 2017 · f2224e4 · f2224e4
1 parent b0d1c8f
commit f2224e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/modules/Transition/Transition.d.ts b/src/modules/Transition/Transition.d.ts
@@ -21,7 +21,7 @@ export interface TransitionProps {
   visible?: boolean;
 
   /** Wait until the first "enter" transition to mount the component (add it to the DOM). */
-  mountOnEnter?: boolean;
+  mountOnShow?: boolean;
 
   /**
    * Callback on each transition that changes visibility to shown.

diff --git a/src/modules/Transition/Transition.js b/src/modules/Transition/Transition.js
@@ -31,7 +31,7 @@ export default class Transition extends Component {
     visible: PropTypes.bool,
 
     /** Wait until the first "enter" transition to mount the component (add it to the DOM). */
-    mountOnEnter: PropTypes.bool,
+    mountOnShow: PropTypes.bool,
 
     /**
      * Callback on each transition that changes visibility to shown.
@@ -79,7 +79,7 @@ export default class Transition extends Component {
     animation: 'fade',
     duration: 500,
     visible: true,
-    mountOnEnter: true,
+    mountOnShow: true,
     transitionAppear: false,
     unmountOnHide: false,
   }
@@ -218,7 +218,7 @@ export default class Transition extends Component {
   computeInitialStatuses = () => {
     const {
       visible,
-      mountOnEnter,
+      mountOnShow,
       transitionAppear,
       unmountOnHide,
     } = this.props
@@ -233,7 +233,7 @@ export default class Transition extends Component {
       return { initial: Transition.ENTERED }
     }
 
-    if (mountOnEnter || unmountOnHide) return { initial: Transition.UNMOUNTED }
+    if (mountOnShow || unmountOnHide) return { initial: Transition.UNMOUNTED }
     return { initial: Transition.EXITED }
   }
 

diff --git a/test/specs/modules/Transition/Transition-test.js b/test/specs/modules/Transition/Transition-test.js
@@ -147,7 +147,7 @@ describe('Transition', () => {
       wrapperShallow(
         <Transition
           visible={false}
-          mountOnEnter={false}
+          mountOnShow={false}
           unmountOnHide={false}
         >
           <p />