Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minCharacters and saveRemoteData for Dropdown setting missing? #1124

Closed
kunokdev opened this issue Jan 5, 2017 · 2 comments
Closed

minCharacters and saveRemoteData for Dropdown setting missing? #1124

kunokdev opened this issue Jan 5, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@kunokdev
Copy link

kunokdev commented Jan 5, 2017 •
edited
Loading

Hello,
is minCharacters and/or saveRemoteData property implemented for React Semantic UI Dropdown element? Can't be found in documentation and error such as this appears:

"Warning: Unknown prop saveRemoteData on

tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
@kunokdev kunokdev changed the title minCharacters for Dropdown setting missing? minCharacters and saveRemoteData for Dropdown setting missing? Jan 5, 2017
@levithomason
Copy link
Member

These are indeed missing. Would love a PR that added them :)

@dyesseyumba dyesseyumba mentioned this issue May 21, 2017
Merged
@levithomason
Copy link
Member

Fix coming in #1690. Note, saveRemoteData will not be implemented for the reasons noted in the PR. Short answer, use Redux or some other standard data layer package.

dyesseyumba added a commit to dyesseyumba/Semantic-UI-React that referenced this issue May 22, 2017
@dyesseyumba
feat(Dropdown): Add minCharacters props. Fixes Semantic-Org#1124
254fc19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levithomason @kunokdev