-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkbox onClick provides wrong data [onChange works fine] #1936
Comments
I think that current behaviour is correct. I'll left this issue open, possible @levithomason has another opinion. |
The order of events is correct and the We should update ours to behave identically:
|
I just ran across this issue as well. I'd be interested in trying out a PR for this and will try to put one together for it this week. |
change onClick's checked value to be the new representation of the checked state instead of the representation before the event was triggered BREAKING CHANGE: Checkbox.onClick has changed how the checked property is defined. To migrate update code that references checked property to the opposite value currently assumed. Closes Semantic-Org#1936
✔ BUGS → This form is required:
Steps
Check or uncheck a checkbox
Expected Result
Checked empty checkbox returns true for 'checked' value in data params and vice versa
Actual Result
onClick registers too early and the 'checked' value is what is was prior (inverse of truth)
Version
0.71.3
Testcase
Toggle a checkbox and view the data params for checked. It's the inverse of what it's supposed to be. I'm assuming the onClick event registers before it actually changes.
The text was updated successfully, but these errors were encountered: