style(Loader|Reveal|Segment): propTypes cleanups and typings update #1165
Conversation
Current coverage is 95.88% (diff: 100%)
|
| const { assertRequired } = commonTestHelpers('implementsTextAlignProp', Component) | ||
|
|
||
| describe('aligned (common)', () => { | ||
| assertRequired(Component, 'a `Component`') | ||
|
|
||
| _noDefaultClassNameFromProp(Component, 'textAlign', options) | ||
| _noClassNameFromBoolProps(Component, 'textAlign', options) | ||
|
|
||
| _.each(Component._meta.props.aligned, (propVal) => { |
There was a problem hiding this comment.
The removed portion of the test is the useful part. It makes the assertion that the proper className is added. I see it was removed as it looped over _meta.props.aligned. In fact, this test was doing nothing as the aligned prop name was changed to textAlign!
Instead of removing these assertions, however, let's loop over SUI.TEXT_ALIGNMENTS directly:
_.each(SUI.TEXT_ALIGNMENTS, (propVal) => {
...
})There was a problem hiding this comment.
I'm think we can do there something better 🤔 We can use this pattern with other common tests that relies on meta. Thoughts?
export const implementsTextAlignProp = (Component, alignments = SUI.TEXT_ALIGNMENTS, options = {}) => {
// ...
_.each(alignments, (propVal) => {
// ...
})
}There was a problem hiding this comment.
That would also work. I checked all the usages and all components that implement TEXT_ALIGNMENTS implement all of them. I'm OK with the default pattern as well.
| @@ -854,17 +859,36 @@ export const implementsImageProp = (Component, options = {}) => { | |||
| /** | |||
| * Assert that a Component correctly implements the "textAlign" prop. | |||
| * @param {React.Component|Function} Component The component to test. | |||
| * @param {array} alignments Array of possible alignment positions. | |||
There was a problem hiding this comment.
This can be optional:
-@param {array} alignments
+@param {array} [alignments]
|
Awesome, thank you! |
|
Released in |
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.
Affects following components:
LoaderRevealSegment