feat(Form): add inverted prop
#1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| const FormExampleInverted = () => ( | ||
| <Segment inverted={true}> | ||
| <Form inverted={true}> |
There was a problem hiding this comment.
Boolean props are true by default, let's go with inverted over inverted={true} 👍
| @@ -9,6 +9,11 @@ const FormFormVariationsExamples = () => ( | |||
| description='A form can vary in size' | |||
| examplePath='collections/Form/Variations/FormExampleSize' | |||
| /> | |||
| <ComponentExample | |||
| title='Inverted' | |||
| description='A form on a dark background may have to invert its color scheme' | |||
There was a problem hiding this comment.
Period after description please, we're currently trying to standardize this.
| @@ -258,11 +261,13 @@ export default class Form extends Component { | |||
| success, | |||
| warning, | |||
| widths, | |||
| inverted, | |||
There was a problem hiding this comment.
Please alphabetically sort the destructured props.
|
Thanks much for the PR! This looks great, made a couple minor comments for you. |
levithomason
changed the title
inverted prop
vageeshb
force-pushed
the
feature/form-inverted
branch
from
d5d9187
to
f91f223
Compare
|
Please, don't forget about typings. |
vageeshb
force-pushed
the
feature/form-inverted
branch
from
f91f223
to
5da7090
Compare
Current coverage is 95.89% (diff: 100%)@@ master #1218 diff @@
==========================================
Files 879 880 +1
Lines 4897 4899 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4696 4698 +2
Misses 201 201
Partials 0 0
|
|
@levithomason Updated with feedback |
levithomason
requested changes
Jan 24, 2017
| <Form inverted> | ||
| <Form.Group widths='equal'> | ||
| <Form.Field label='First name' control='input' placeholder='First name' /> | ||
| <Form.Field label='Last name' control='input' placeholder='Last name' /> |
There was a problem hiding this comment.
Apologies that I missed this on the first pass. Let's use the shorthand <Form.Input /> for brevity. I like to keep the doc examples as slim as possible:
-<Form.Field label='First name' control='input' placeholder='First name' />
+<Form.Input label='First name' placeholder='First name' />| @@ -37,6 +37,7 @@ describe('Form', () => { | |||
| common.propKeyOnlyToClassName(Form, 'reply') | |||
| common.propKeyOnlyToClassName(Form, 'success') | |||
| common.propKeyOnlyToClassName(Form, 'warning') | |||
| common.propKeyOnlyToClassName(Form, 'inverted') | |||
There was a problem hiding this comment.
Nit: alphabetical by prop name please. I realize many are out of order, however, there is a current effort to update these.
| @@ -263,6 +267,7 @@ export default class Form extends Component { | |||
| const classes = cx( | |||
| 'ui', | |||
| size, | |||
| useKeyOnly(inverted, 'inverted'), | |||
There was a problem hiding this comment.
Nit: alphabetical by prop name please
vageeshb
force-pushed
the
feature/form-inverted
branch
from
5da7090
to
f775f0c
Compare
levithomason
approved these changes
Jan 24, 2017
|
Thanks for the extra fixes! |
|
Released in |
DomiR
added a commit
to DomiR/Semantic-UI-React
that referenced
this pull request
Jan 26, 2017
* Semantic-Org/master: (111 commits) fix(docs): fix usage of arrow function (Semantic-Org#1228) fix(Icon): Incorrect definition in typings (Semantic-Org#1225) fix(Button): fix `tabIndex` in typings (Semantic-Org#1224) fix(typings): add item prop to the DropdownProps (Semantic-Org#1223) docs(examples): add missing `key` props (Semantic-Org#1220) docs(changelog): update changelog [ci skip] 0.64.4 feat(Form): add `inverted` prop (Semantic-Org#1218) fix(ComponentExample): use explicit babel presets (Semantic-Org#1219) style(Button): update typings and propTypes usage (Semantic-Org#1216) style(Embed): update typings and propTypes usage (Semantic-Org#1217) chore(package): support for jsnext:main (Semantic-Org#1210) style(Step): update typings, tests and propTypes usage (Semantic-Org#1203) fix(Portal): do not take focus after first render (Semantic-Org#1215) style(Table|mixed): update typings, tests and propTypes usage (Semantic-Org#1200) fix(Dropdown): use `item` instead of `as={Menu.Item}` (Semantic-Org#659) fix(Dropdown): respect `closeOnBlur={false}` (Semantic-Org#1148) style(Breadcrumb): update typings and propTypes usage (Semantic-Org#1209) style(Dimmer): update typings (Semantic-Org#1208) fix(Divider|FormInput): fix the broken typings (Semantic-Org#1179) ...
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invertedboolean property #1212