Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): make TableHeaderCell sorted optional #1236

Merged
merged 1 commit into from
Jan 27, 2017
Merged

fix(typings): make TableHeaderCell sorted optional #1236

merged 1 commit into from
Jan 27, 2017

Conversation

squirly
Copy link
Contributor

@squirly squirly commented Jan 27, 2017

No description provided.

@layershifter layershifter changed the title fix(typings) Remove required field from TableHeaderCell fix(Table): remove required field from TableHeaderCell typings Jan 27, 2017
@layershifter
Copy link
Member

@squirly Thanks for PR

@codecov-io
Copy link

codecov-io commented Jan 27, 2017

Current coverage is 95.89% (diff: 100%)

Merging #1236 into master will not change coverage

@@             master      #1236   diff @@
==========================================
  Files           880        880          
  Lines          4901       4901          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4700       4700          
  Misses          201        201          
  Partials          0          0          

Powered by Codecov. Last update d3b1acd...cbd32b7

@squirly
Copy link
Contributor Author

squirly commented Jan 27, 2017

The CircleCI build did not report back. I probably needs to be rebuilt. They did have some degradation earlier today at the same time this build ran.

@levithomason
Copy link
Member

Thanks, appears to have passed :)

@levithomason levithomason changed the title fix(Table): remove required field from TableHeaderCell typings fix(typings): make TableHeaderCell sorted optional Jan 27, 2017
@levithomason levithomason merged commit fe85731 into Semantic-Org:master Jan 27, 2017
@levithomason
Copy link
Member

Released in semantic-ui-react@0.64.5.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
fix(typings): make TableHeaderCell `sorted` optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants