fix(DropdownItem): add className to element shorthands #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1256 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 140 140
Lines 2392 2393 +1
==========================================
+ Hits 2386 2387 +1
Misses 6 6
Continue to review full report at Codecov.
|
levithomason
force-pushed
the
fix/dropdown-item-shorthand
branch
from
48c40c0
to
6d732ea
Compare
levithomason
force-pushed
the
fix/dropdown-item-shorthand
branch
from
6d732ea
to
7e4c956
Compare
|
Released in |
harel
pushed a commit
to harel/Semantic-UI-React
that referenced
this pull request
Feb 25, 2017
…1256) * fix(DropdownItem): add className to element shorthands * docs(DropdownExampleDescription): fix markup * test(Dropdown): fix shorthand tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing elements to the
textordescriptionprop for aDropdownItem, the appropriateclassNamevalues were not added. TheclassNamewas only added for primitive value shorthand.This PR moves the
classNamevalues to thedefaultPropscallback for each shorthand so they are always added to all resulting shorthand elements.