Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(List): update typings and remove propTypes #1270

Merged
merged 1 commit into from
Feb 2, 2017
Merged

Conversation

layershifter
Copy link
Member

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.

@codecov-io
Copy link

Codecov Report

Merging #1270 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master    #1270      +/-   ##
==========================================
+ Coverage   95.91%   95.91%   +<.01%     
==========================================
  Files         882      882              
  Lines        4917     4919       +2     
==========================================
+ Hits         4716     4718       +2     
  Misses        201      201
Impacted Files Coverage Δ
src/elements/List/ListList.js 100% <ø> (ø)
src/elements/List/ListContent.js 100% <ø> (ø)
src/elements/List/List.js 100% <ø> (ø)
src/elements/List/ListIcon.js 100% <ø> (ø)
src/elements/List/ListItem.js 100% <100%> (ø)
src/elements/List/ListDescription.js 100% <100%> (ø)
src/elements/List/ListHeader.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cdabd2...a5edce2. Read the comment docs.

@levithomason levithomason merged commit e4f31ad into master Feb 2, 2017
@levithomason levithomason deleted the style/list branch February 2, 2017 09:03
@levithomason
Copy link
Member

💥

@levithomason
Copy link
Member

Released in semantic-ui-react@0.64.7.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants