-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(Sidebar): update typings and propTypes usage #1296
Conversation
width: ['very thin', 'thin', 'wide', 'very wide'], | ||
}, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now You're Gone 🎶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
fc9d30f
to
87c2992
Compare
_.each(_.get(Sidebar, '_meta.props.direction'), propValue => { | ||
shallow(<Sidebar direction={propValue} />).should.have.className(propValue) | ||
}) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I replaced this test with propValueOnlyToClassName
.
it('renders children of the sidebar', () => { | ||
const wrapper = mount(<Sidebar><span /></Sidebar>) | ||
wrapper.children().at(0).should.have.tagName('span') | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is performed by rendersChildren()
test.
Codecov Report
@@ Coverage Diff @@
## master #1296 +/- ##
==========================================
- Coverage 99.74% 99.74% -0.01%
==========================================
Files 140 140
Lines 2394 2393 -1
==========================================
- Hits 2388 2387 -1
Misses 6 6
Continue to review full report at Codecov.
|
width: ['very thin', 'thin', 'wide', 'very wide'], | ||
}, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😸
Released in |
This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.