Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Sidebar): update typings and propTypes usage #1296

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

layershifter
Copy link
Member

This PR is part of work for removing propTypes in production bundle (#524, #731).
Also, cleanups and updates typings for #1072.

width: ['very thin', 'thin', 'wide', 'very wide'],
},
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now You're Gone 🎶

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

_.each(_.get(Sidebar, '_meta.props.direction'), propValue => {
shallow(<Sidebar direction={propValue} />).should.have.className(propValue)
})
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced this test with propValueOnlyToClassName.

it('renders children of the sidebar', () => {
const wrapper = mount(<Sidebar><span /></Sidebar>)
wrapper.children().at(0).should.have.tagName('span')
})
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is performed by rendersChildren() test.

@codecov-io
Copy link

codecov-io commented Feb 8, 2017

Codecov Report

Merging #1296 into master will not impact coverage by -0.01%.

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%     
==========================================
  Files         140      140              
  Lines        2394     2393       -1     
==========================================
- Hits         2388     2387       -1     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Sidebar/SidebarPusher.js 100% <ø> (ø)
src/modules/Sidebar/Sidebar.js 53.84% <100%> (-3.3%)
src/modules/Sidebar/SidebarPushable.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070178e...87c2992. Read the comment docs.

width: ['very thin', 'thin', 'wide', 'very wide'],
},
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@levithomason levithomason merged commit a955f0e into master Feb 11, 2017
@levithomason levithomason deleted the style/sidebar branch February 11, 2017 06:15
@levithomason
Copy link
Member

Released in semantic-ui-react@0.64.8.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants